Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Remove MvcUriBuilder and use javax.ws.rs.core.UriBuilder #190

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

lefloh
Copy link
Contributor

@lefloh lefloh commented Aug 24, 2018

Implements mvc-spec/mvc-spec#189.

There's also one unrelated change in org.mvcspec.ozark.event.MvcEventImpl as MvcEvent@getId is already removed (#188).

@chkal
Copy link
Contributor

chkal commented Aug 25, 2018

Thanks @lefloh. Looks like the build is currently broken on master. I'm currently fixing that. I'll ping you as soon the build is back to green. Perhaps you could rebase after that?

@chkal chkal self-assigned this Aug 25, 2018
@lefloh
Copy link
Contributor Author

lefloh commented Aug 25, 2018

Sure!

@chkal
Copy link
Contributor

chkal commented Aug 25, 2018

I just fixed master. Travis seems to have some issues that the moment, but I'm pretty sure the code is fine now.

Unfortunately there is a conflict with your PR now, as I removed the MvcEventImpl class. :-(

Could you perhaps rebase against master?

@lefloh
Copy link
Contributor Author

lefloh commented Aug 25, 2018

Done.

@chkal
Copy link
Contributor

chkal commented Aug 25, 2018

Thanks a lot! 🍻

@chkal chkal changed the title Remove MvcUriBuilder and use javax.ws.rs.core.UriBuilder [ON-HOLD] Remove MvcUriBuilder and use javax.ws.rs.core.UriBuilder Aug 25, 2018
@chkal chkal changed the title [ON-HOLD] Remove MvcUriBuilder and use javax.ws.rs.core.UriBuilder Remove MvcUriBuilder and use javax.ws.rs.core.UriBuilder Aug 25, 2018
@chkal
Copy link
Contributor

chkal commented Aug 27, 2018

I was about to merge this one, but it looks like the TCK fails for some reason

[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   UriBuildingTest.encodingMatrixParam:184 » FailingHttpStatusCode 500 Internal S...
[ERROR]   UriBuildingTest.encodingPathParam:148 » FailingHttpStatusCode 500 Internal Ser...
[ERROR]   UriBuildingTest.encodingQueryParam:166 » FailingHttpStatusCode 500 Internal Se...
[ERROR]   UriBuildingTest.mapMatrixParam:130 » FailingHttpStatusCode 500 Internal Server...
[ERROR]   UriBuildingTest.mapPathParam:94 » FailingHttpStatusCode 500 Internal Server Er...
[ERROR]   UriBuildingTest.mapQueryParam:112 » FailingHttpStatusCode 500 Internal Server ...
[ERROR]   UriBuildingTest.simpleUriViaEl:76 » FailingHttpStatusCode 500 Internal Server ...
[ERROR]   UriBuildingTest.supportsUriRef:202 » FailingHttpStatusCode 500 Internal Server...
[INFO] 
[ERROR] Tests run: 44, Failures: 0, Errors: 8, Skipped: 0

@chkal
Copy link
Contributor

chkal commented Aug 27, 2018

Hmmm... Looks like the TCK doesn't compile against the latest spec snapshots. I'll fix this later today. Stay tuned.. 😜

@chkal
Copy link
Contributor

chkal commented Aug 27, 2018

Looks like the tests and the TCK passes now. Merging now!

@chkal chkal merged commit d4de35b into mvc-spec:master Aug 27, 2018
@chkal chkal added this to the 1.0.0-m04 milestone Aug 27, 2018
@lefloh lefloh deleted the remove-mvc-uri-builder branch August 27, 2018 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants