This repository has been archived by the owner on Dec 15, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Remove MvcUriBuilder and use javax.ws.rs.core.UriBuilder #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @lefloh. Looks like the build is currently broken on |
Sure! |
I just fixed Unfortunately there is a conflict with your PR now, as I removed the Could you perhaps rebase against |
lefloh
force-pushed
the
remove-mvc-uri-builder
branch
from
August 25, 2018 08:27
80ae6b1
to
6ebda0a
Compare
Done. |
Thanks a lot! 🍻 |
chkal
changed the title
Remove MvcUriBuilder and use javax.ws.rs.core.UriBuilder
[ON-HOLD] Remove MvcUriBuilder and use javax.ws.rs.core.UriBuilder
Aug 25, 2018
chkal
changed the title
[ON-HOLD] Remove MvcUriBuilder and use javax.ws.rs.core.UriBuilder
Remove MvcUriBuilder and use javax.ws.rs.core.UriBuilder
Aug 25, 2018
lefloh
force-pushed
the
remove-mvc-uri-builder
branch
from
August 26, 2018 10:07
6ebda0a
to
830e9a7
Compare
I was about to merge this one, but it looks like the TCK fails for some reason
|
Hmmm... Looks like the TCK doesn't compile against the latest spec snapshots. I'll fix this later today. Stay tuned.. 😜 |
Looks like the tests and the TCK passes now. Merging now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements mvc-spec/mvc-spec#189.
There's also one unrelated change in
org.mvcspec.ozark.event.MvcEventImpl
asMvcEvent@getId
is already removed (#188).