-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expand: environment variables are no longer case insensitive on Windows #325
Comments
Interesting - thanks for the report. We already do test on Windows via Travis, but as you can imagine, Windows environments can vary quite a lot. I understand that environment variables in Windows are case insensitive, whereas they are case sensitive on unix-like systems. That is, We used to take this into account when constructing an interpreter, but it seems like that piece of code was dropped recently. I can't think why I'd remove it, so I think it was just a mistake. I'll re-add it and add a regression test. |
We were doing this in the interp package before the code was extracted into the expand package. Getting rid of that was a mistake, and led to subtle bugs on plain Windows. To prevent this from happening again, add a regression unit test, as well as a full interpreter test via os.Setenv in the interp package. Fixes #325.
@RossHammer could you please test a master build? I'm fairly positive that the commit above should fix it for you, but I'd like confirmation from you before doing a bugfix release. |
That seems like it fixed it. Thanks |
When I run commands on my system I get the following when trying to run any exe
After doing some digging I noticed my path environment variable is
Path
notPATH
for some reason. This is a relatively fresh install of windows as well. Once I changed it toPATH
everything started working betterThe text was updated successfully, but these errors were encountered: