Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/shfmt: document how EditorConfig's "ignore" works #1038

Merged
merged 1 commit into from
Dec 26, 2023
Merged

cmd/shfmt: document how EditorConfig's "ignore" works #1038

merged 1 commit into from
Dec 26, 2023

Conversation

mvdan
Copy link
Owner

@mvdan mvdan commented Oct 13, 2023

(see commit message)

For #1037.

@mvdan
Copy link
Owner Author

mvdan commented Oct 13, 2023

@dcd-arnold let me know if this is clearer now.

dcd-arnold
dcd-arnold reviewed Oct 13, 2023
View reviewed changes
Copy link

@dcd-arnold dcd-arnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it clearer. However, this is still counter-intuitive.

cmd/shfmt/shfmt.1.scd Outdated Show resolved Hide resolved
@mvdan
cmd/shfmt: document how EditorConfig's "ignore" works
7779139 
In particular, that it only applies when formatting directories.
When directly formatting files, we don't ignore anything.

For #1037.
@mvdan mvdan merged commit bcbe8ac into master Dec 26, 2023
14 checks passed
@mvdan mvdan deleted the man-page-ignore branch December 26, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcd-arnold dcd-arnold dcd-arnold left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvdan @dcd-arnold