syntax: allow escaped newlines to precede unquoted words again #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of fixing #832, to prevent breaking some programs with escaped newlines, I went slightly too far with the tightening of the rules. The input script foo <<< \ "bar baz" would now reformat as foo <<< "\ bar baz" The script is functionally the same, but it looks objectively worse. It is harmless to allow a leading escaped newline when not quoted, as it doesn't break any programs nor result in worse formatting. Note that the script foo=\ bar will still reformat as `foo=bar`, so in that case we keep the recent change in behavior. That case is different, as we can't safely indent the continuing line - thus we can't produce good formatting unless we join the lines. While here, remove incomplete code that I had left commented out in the last patch, and then forgot to remove before merging. Fixes #873.
riacataquian
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)
Fixes #873.