Respect env RUBY_DBUS_ENDIANNESS=B (or =l) for outgoing messages. #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since v0.2.1 there was a first marshalling to find out the body size for the header and then we threw the result away and redid it. Reuse the result.
A global switch of the endianness of the sent messages. This is probably useful only to tease peer implementations: dbus-daemon will forward our messages to them with the original endianness.
mvidner
force-pushed
the
other-endianness
branch
from
120c6c8
to
ab88b12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also: Message#marshall speedup: don't marshall the body twice.