-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced Fixnum by Integer for Ruby2.4 #67
Conversation
1 similar comment
Hey, any news on this issue ? Will it be fix/merge soon ? |
I haven't heard of any news, but I sure hope for some :) |
It seems the project is abandoned... |
no, project still live and is used. @mvidner can you check it? |
In general problem with this pull request is that ruby-dbus still support 2.0.0 where Fixnum is not child of Integer, so it won't work. So this pull request is quite tricky as it means to drop support for older ruby versions. |
So in general this pr is correct, but it can be merged in current only when we drop support for all ruby versions below 2.4.0. |
That's not the case. Integer has been the superclass of Fixnum since at least the Pickaxe book. |
The 2.0.0 test failed because Nokogiri has in the meantime stopped supporting that version. We should do the same since even 2.1.0 has fallen out of support. |
@plassa-b Thank you! |
Well, it wasn't that hard :D |
No description provided.