Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Fixnum by Integer for Ruby2.4 #67

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Conversation

clery
Copy link
Contributor

@clery clery commented Mar 24, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 87.868% when pulling eb6bae3 on plassa-b:master into 2646c0d on mvidner:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 87.868% when pulling eb6bae3 on plassa-b:master into 2646c0d on mvidner:master.

@disastrous-charly
Copy link

Hey, any news on this issue ?

Will it be fix/merge soon ?

@clery
Copy link
Contributor Author

clery commented Apr 11, 2017

I haven't heard of any news, but I sure hope for some :)

@disastrous-charly
Copy link

It seems the project is abandoned...

@jreidinger
Copy link
Collaborator

no, project still live and is used. @mvidner can you check it?

@jreidinger
Copy link
Collaborator

In general problem with this pull request is that ruby-dbus still support 2.0.0 where Fixnum is not child of Integer, so it won't work. So this pull request is quite tricky as it means to drop support for older ruby versions.

@jreidinger
Copy link
Collaborator

So in general this pr is correct, but it can be merged in current only when we drop support for all ruby versions below 2.4.0.

@mvidner
Copy link
Owner

mvidner commented Apr 12, 2017

2.0.0 where Fixnum is not child of Integer

That's not the case. Integer has been the superclass of Fixnum since at least the Pickaxe book.

@mvidner
Copy link
Owner

mvidner commented Apr 12, 2017

The 2.0.0 test failed because Nokogiri has in the meantime stopped supporting that version. We should do the same since even 2.1.0 has fallen out of support.

@mvidner mvidner merged commit 742e041 into mvidner:master Apr 12, 2017
@mvidner
Copy link
Owner

mvidner commented Apr 12, 2017

@plassa-b Thank you!

@clery
Copy link
Contributor Author

clery commented Apr 12, 2017

Well, it wasn't that hard :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants