-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor problem with permissions and cygwin ~/.cache folder on windows #187
Comments
Okay I see that stopping docker in windows let me remove that cached files. |
Thank you for reporting this! Even if the file I'll investigate. |
That is an important hint. Are there other files left than Unfortunately I cannot run docker in Windows on my laptop, so it is a bit hard to debug. |
Thanks for the fast reply :)
If I stop the process directly through the cygwin bash with a SIGINT it shows this:
As i can see the last debug lines tries to remove the
|
Another interesting thing is that the unique file i cannot delete is specifically the |
I've fixed one issue i see in the output of
|
I've included a non-elegant hotfix to wait for the container exit code before deleting the cache. Maybe that helps. If yes, I'll think about a more proper solution. Edit: Could you please run with |
I'm not at home right now, but i'll check it today or tomorrow. Thanks for that quick fix :) |
Still not working, but at least the folder of each container created is removed inside .cache folder. Maybe the problem is related with the .cache folder that is somehow retained by docker.
Maybe a solution could be create a .cache-containerid folder each time x11docker run and remove it on SIGINT. I don't know what could be :( Edit: Still working if i remove .cache after closing Docker Desktop |
Currently x11docker creates a cache subfolder for each container in
It would be possible to create a
I've fixed this issue, |
I think that because it is possible to delete the folder when docker is stopped, but I am not 100% sure.
Yes, that would pollute the home folder of the user.
Ok, i have tried with --debug option. I've removed .cached folder and the output is that:
x11docker creates the .cache folder, but it ends without subfolders. That's a good sign.
If I try to run it a second time, the output is the same. I attach it anyways:
|
Thank you for your patience with the tests. Your cache check with I've added two additional Could you please try again, with and without |
No problem. I really like this project and I see good potential use cases for this. If I have time I would like to contribute a little bit in the future and check different environments :). I see a little typo error in lines in lines 509 and 6929. I substituted this lines with: After install it the output of the first try is this. As usual it works:
Output of the second try:
Maybe it's important to say that my cygwin folder is located in C:\cygwin64 |
Good to see that The second log shows wrong file ownership of
In the first log it is ok. I have no idea why the first startup works fine, but the second one does not. There should be no relation at all between the two starts. I suspect one line in x11docker does not need this |
Ok, now it's working perfectly :). Here is the log if it is necessary.
Thank you very much for your time. I'll notice if I see other issues :) |
Great! :-) Could you please run once more with In your prvious log I see two issues:
Should be fixed now, the error should not be shown anymore,
x11docker disables the composite extension for XWin. You can enable it with inofficial/experimental option |
Of course. That's the log running with
|
Thanks! Overall the startup seems to be quite slow, it takes more than half a minute. |
Hi, first of all congrats for the project. I really like it.
I had started a complete desktop with x11docker in Ubuntu without problems. In Windows I'm using xwin in cygwing installed.
When I use x11docker for the first time, it works correctly, problems start when I try to run x11docker after that first try.
Some files created at
'~/.cache'
(C:\cygwin64\home\<username>\.cache\
in Windows) are created with some weird permissions. The output of x11docker is this:I've tried to delete these files as admin, and the unique way I've been able to delete them was starting windows in safe mode and delete it with the file explorer.
After removing these files, the first time you start x11docker again it works fine.
The text was updated successfully, but these errors were encountered: