concurrent projects polling; syntax fixes #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvisonneau
reviewed
Apr 16, 2020
There was a problem hiding this comment.
Thanks a lot for this thorough revision of the logic @inge4pres! I have learnt a lot of things 🙏🙇♂️
I made a few comments on which we can discuss further but on overall I am happy to see it merged 👍
added 4 commits
April 16, 2020 14:56
…l_seconds` and corresponding attribute in Config field
…ntax; write changelog
|
Hey there @mvisonneau I see this PR is growing a lot! all the discussions should be addressed, please have a look 😄 I updated the changelog with the content of the changes |
mvisonneau
requested changes
Apr 16, 2020
There was a problem hiding this comment.
thanks a lot @inge4pres, this looks really good! I just left a small comment but otherwise LGTM 👍
inge4pres
force-pushed
the
concurrent-polling
branch
from
0e3acd4
to
3569450
Compare
mvisonneau
approved these changes
Apr 17, 2020
inge4pres
pushed a commit
to inge4pres/gitlab-ci-pipelines-exporter
that referenced
this pull request
Apr 20, 2020
…jects polling, adding tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
here are addressed some of the design improvements highlighted in #86.
The main area is around pollProjects architecture that is now fully concurrent compared to the previous long-polling version.
There are also some minor cosmetic stuff like avoiding init() for metrics registry and some syntax simplifications.