Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run egui pass after bevy_ui #53

Merged
merged 1 commit into from
Jan 16, 2022
Merged

Conversation

jakobhellermann
Copy link
Contributor

should fix #52

@Hilku can you confirm by putting

[patch.crates-io]
bevy_egui = { git = "https://github.com/jakobhellermann/bevy_egui", branch = "after-ui-pass" }

in your Cargo.toml?

@jakobhellermann
Copy link
Contributor Author

This is a bit ugly because it uses a hardcoded string out of bevy_ui but I can't think of a better solution right now.

@Hilku
Copy link

Hilku commented Jan 9, 2022

I tried it, and it seems to be better, but bevy_egui is still sometimes rendered "under" bevy_ui.

@mvlabat
Copy link
Owner

mvlabat commented Jan 16, 2022

I'll merge this until we can have a better fix. @Hilku unfortunately, I wasn't able to reproduce the problem when bevy_egui still gets rendered "under" bevy_ui sometimes. If you have an example, feel free to open a new issue and share it, I'll try to look into it.

@mvlabat mvlabat merged commit 2064dd4 into mvlabat:main Jan 16, 2022
@jakobhellermann jakobhellermann deleted the after-ui-pass branch November 13, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bevy_egui race condition with bevy_ui
3 participants