Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checksum-dependency-plugin for verification of plugin/dependency checksums #44

Closed
wants to merge 1 commit into from

Conversation

vlsi
Copy link

@vlsi vlsi commented Sep 9, 2019

checksum-dependency-plugin is a superset of gradle-witness, and it enables to increase the level of security.

See https://github.com/vlsi/vlsi-release-plugins#checksum-dependency-plugin

Signed-off-by: Vladimir Sitnikov sitnikov.vladimir@gmail.com

…checksums

`checksum-dependency-plugin` is a superset of `gradle-witness`, and it enables to increase the level of security.

See https://github.com/vlsi/vlsi-release-plugins#checksum-dependency-plugin

Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
@mvmike
Copy link
Owner

mvmike commented Sep 10, 2019

I see no need of checking checksums of all libs since both repositories used in this project (jcenter and google) are accessed through https

@mvmike mvmike closed this Sep 10, 2019
@vlsi
Copy link
Author

vlsi commented Sep 10, 2019

Ok, I see your point.

By the way, here's an explanation why https is not enough: https://medium.com/@vladimirsitniko/dependency-verification-checksum-vs-pgp-582e76207019?sk=7485298b76eaf9f935b899b002f4c3b5

Here's a case with JCenter: https://blog.autsoft.hu/a-confusing-dependency/
Here's a case with NPM: https://news.ycombinator.com/item?id=14901566

@msgilligan
Copy link

https

both repositories used in this project (jcenter and google) are accessed through https

Using https only protects from tampering while in-transit. If someone hacks the server or manages to re-publish tampered binaries to the server that won't be detected/prevented by https.

@mvmike
Copy link
Owner

mvmike commented Sep 11, 2019

Got the point. Still, it only helps if the file is tampered after being upgraded on the project along with its checksum (many of the checksums added to the PR are not officially published by their respective owners).

I'm aware that from the security perspective we should always be aiming for risk reduction, I just think that this is covering a single and very un-probable scenario thus making it not worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants