Task 39 fuzzer

[sobuch]

simple fuzzer using radamsa

[sobuch]

now shows logs in stderr, for the time being I think its better to leave the other exit codes from mnemoniccli.ExitCode as fails, since they seem more likely to indicate problems with fuzzer than the code.

Eg. 'EX_NOINPUT = 66
"""An input file (not a system file) did not exist or was not readable."""'

[sobuch]

i think the rest of style issues are false positives, as we have to check against several values. If you know of a way to do that dirrectly please let me know

[mvondracek]

@sobuch

mnemoniccli -g -e entropy_bin -s seed -m mnemonic -f bin -ll debug &>out
exit_code=$?
if [[ ${exit_code} != 0 && ${exit_code} != 65 ]] ;

[mvondracek]

@sobuch, Please add fuzzing of --password for various actions.

[sobuch]

@sobuch

mnemoniccli -g -e entropy_bin -s seed -m mnemonic -f bin -ll debug &>out
exit_code=$?
if [[ ${exit_code} != 0 && ${exit_code} != 65 ]] ;

this is the same thing as i did just longer, what codeclimate is sugesting is something like
if ! make mytarget then echo "Build failed" fi
which I dont know how to do

[sobuch]

rebased on dev

[mvondracek]

$? gives you exit code of last command, so it's better to read value once into variable and then do comparison on several places. Variable stays the same, $? changes if you execute another command in the meantime.

[sobuch]

the comparison is done only in one place for each run of mnemoniccli, 'if [[ ... ]]' is a single command as far as I know

[mvondracek]

I'm afraid this is issue like "it works in this case, but different approach is better in general" :D Do you want to fix this or should I mark it as wontfix?

[sobuch]

No, mark it as false positive instead, it's not that it only works in this case. Codeclimate wants us not to use '$?' variable at all, which cant be done in this case.

[mvondracek]

Shellcheck (code climate) is fine with approach I suggested as solution. It does not have problem with $?.

[sobuch]

then you found a way around its checks, you still use indirect check ($?) not direct, which is what was reported

[mvondracek]

• Since the command and its status test are decoupled, inserting an innocent command like echo "make finished" after make will cause the if statement to silently start comparing echo's status instead.
• The value of $? is overwritten by [/[[, so you can't get the original value in the relevant then/else block (e.g. if mycmd; then echo "Success"; else echo "Failed with $?"; fi).
  https://github.com/koalaman/shellcheck/wiki/SC2181

[mvondracek]

Closes #39

[mvondracek]

Pending review, @lsolodkova

[codeclimate]

Code Climate has analyzed commit a95de36 and detected 0 issues on this pull request.

View more on Code Climate.