Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support android #165

Merged
merged 5 commits into from
Sep 10, 2023
Merged

Support android #165

merged 5 commits into from
Sep 10, 2023

Conversation

ziye-dm
Copy link
Contributor

@ziye-dm ziye-dm commented Aug 15, 2023

Use the same configs with QNX and it's working.

@@ -99,7 +107,7 @@ cache_entries_linux_and_macos = {
cache_entries_qnx = {
"ENABLE_SOURCE_SPECIFIC_MULTICAST": "OFF",
"ENABLE_IPV6": "OFF",
"CMAKE_SYSTEM_NAME": "QNX",
"CMAKE_SYSTEM_NAME": "QNX_OR_ANDROID",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it good to call it QNX_OR_ANDROID & cache_entries_qnx?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add CI for different platforms also? @mvukov

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming is fine. Thanks for the contribution. BTW, can you share how would you use ROS+android?

Regarding CI: ATM I dunno how would we set up CI for Android. IMO, this PR would be good to go as-is, once the CI is green.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. We focus on the AR/VR usage for car cabin and both automotive OS and AR/VR devices may use Android.

A simplest CI could be just the compilation for @platforms//os:android?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, compilation doesn't mean that e.g. a deployment works. Do Python-based ROS 2 deployments (ros2_launch targets) work on Android for you? IMO, this is a bit more involved issue -- we can leave this for a follow-up.

@ziye-dm ziye-dm force-pushed the ziye/android branch 2 times, most recently from 299d2bf to 21be637 Compare September 5, 2023 08:41
Copy link
Owner

@mvukov mvukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! I left a couple of small comments.

repositories/cyclonedds.BUILD.bazel Outdated Show resolved Hide resolved
repositories/iceoryx.BUILD.bazel Outdated Show resolved Hide resolved
repositories/rcutils.BUILD.bazel Outdated Show resolved Hide resolved
@@ -99,7 +107,7 @@ cache_entries_linux_and_macos = {
cache_entries_qnx = {
"ENABLE_SOURCE_SPECIFIC_MULTICAST": "OFF",
"ENABLE_IPV6": "OFF",
"CMAKE_SYSTEM_NAME": "QNX",
"CMAKE_SYSTEM_NAME": "QNX_OR_ANDROID",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, compilation doesn't mean that e.g. a deployment works. Do Python-based ROS 2 deployments (ros2_launch targets) work on Android for you? IMO, this is a bit more involved issue -- we can leave this for a follow-up.

@ziye-dm ziye-dm requested a review from mvukov September 6, 2023 09:26
@mvukov mvukov merged commit 105b26c into mvukov:main Sep 10, 2023
5 checks passed
@mvukov
Copy link
Owner

mvukov commented Sep 10, 2023

Thanks for the contribution! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants