Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler error for MessageHandler #2

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Conversation

fengyuxx
Copy link

No description provided.

@szotp
Copy link
Contributor

szotp commented Jul 11, 2019

Hi @fengyuxx thanks for your MR. Since this repo was created we discovered another problem which is not yet fixed by this repo. You may need to:

  1. Copy autogenerated registerWithRegistry into AppDelegate.m

  2. Comment out FLTFirebaseMessagingPlugin.

  //[FLTFirebaseMessagingPlugin registerWithRegistrar:[registry registrarForPlugin:@"FLTFirebaseMessagingPlugin"]];
  [FlutterApnsPlugin registerWithRegistrar:[registry registrarForPlugin:@"FlutterApnsPlugin"]];
  1. Sync registerWithRegistry every time you add new plugins.

It's tricky because the order of registration matters: when FlutterApnsPlugin registered before FLTFirebaseMessagingPlugin then everything worked fine. We probably need to use method swizzling to nullify FLTFirebaseMessagingPlugin registerWithRegistrar or fork the firebase plugin to disable it on iOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants