Handle negated patterns according to ssh_config(5) #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norrisjeremy
approved these changes
May 28, 2024
There was a problem hiding this comment.
I'm good with this assuming that Github CI indicates build succeeds & all unit tests pass.
I believe @mwiede will need to approve CI build for this PR.
|
@bmiddaugh Can you you please run the following and repush to fix formatting? |
|
@norrisjeremy Yes. I pushed a new commit fixing the formatting |
norrisjeremy
approved these changes
May 28, 2024
|
Looks like I need to run the formatter again with the new changes...doing that now |
|
You can confirm locally by make sure to always run |
norrisjeremy
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #564