Mark this as compatible with GNOME 3.38 and 40 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedora 33 ships with GNOME 3.38 (but with version validation disabled) and this extension works fine there. Fedora 34 beta has GNOME 40 (with version validation enabled) and the extension works once the version is added to the list of supported versions. Signed-off-by: Michel Alexandre Salim <michel@michel-slm.name>
|
Using with #1 on gnome 40 I am getting warnings: const shellVersion = Config.PACKAGE_VERSION.split(".").map(Number).reduce(
function(a, x) {
return 100 * a + x;
});3.36.1 become 33601, but 40.0 become 4000 |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora 33 ships with GNOME 3.38 (but with version validation disabled)
and this extension works fine there. Fedora 34 beta has GNOME 40 (with
version validation enabled) and the extension works once the version
is added to the list of supported versions.
Signed-off-by: Michel Alexandre Salim michel@michel-slm.name
This change is