Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync source in repo and in LuaRocks #32

Closed
moteus opened this issue Feb 24, 2016 · 7 comments
Closed

Sync source in repo and in LuaRocks #32

moteus opened this issue Feb 24, 2016 · 7 comments
Assignees

Comments

@moteus
Copy link

moteus commented Feb 24, 2016

In LuaRocks version 0.5 drivers loaded as dbd.<driver> but in current repo they loaded like dbd<driver>

@sparked435 sparked435 self-assigned this Feb 24, 2016
@sparked435
Copy link
Collaborator

This was me, when I built the original Luarocks modules some time ago. It was partially taste but also it made using the built in Luarocks build system easier.

I would have synced it sooner but doing so will break the Visual Studio project and I have no means of supporting Windows at this time.

@fliiiix
Copy link

fliiiix commented Feb 23, 2017

Is there any progress? Since https://luarocks.org/modules/luarocks/luadbi still points to google code

@moteus
Copy link
Author

moteus commented Aug 8, 2017

@sparked435 So you do no decide change source on this repo to use dbd.<driver> like in version 0.5 and use dbd<driver> notation.
I think because current release on LuaRocks uses such code it worth also change it in currect repo.

@sparked435
Copy link
Collaborator

This issue is still open because I have not yet made the change. :)

I'm looking into seeing if this will break anything on Windows, which is difficult, as I don't have access to any Windows system for development.

@sparked435
Copy link
Collaborator

Fixed in commit bdaf244

@fliiiix
Copy link

fliiiix commented Aug 19, 2017

Cool 👍 fyi: https://luarocks.org/modules/luarocks/luadbi still points to google code!

@sparked435
Copy link
Collaborator

I'm aware. One thing at a time. :)

Currently gearing up for a release, will fix it all at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants