Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag(s) with version numbers #36

Closed
mp1409 opened this issue Sep 22, 2016 · 8 comments
Closed

Add tag(s) with version numbers #36

mp1409 opened this issue Sep 22, 2016 · 8 comments

Comments

@mp1409
Copy link

mp1409 commented Sep 22, 2016

Hi there,
we are in the process of pointing the FreeBSD ports collection to this repo as new location for LuaDBI. Currently the LuaDBI version in FreeBSD ports is "0.5". However we noticed that there are no version number tags in this repo.

Of course we could just map some git commit to version 0.5 on our side. But in a couple of months some other distribution might face the same problem. So it would be great if you could tag the appropriate git commit with something like "v0.5". Thanks :-)

References:

@moteus
Copy link

moteus commented Sep 22, 2016

Checkout #32
I also wait it for a while :)

@mwild1
Copy link
Owner

mwild1 commented Sep 23, 2016

Hmm, that's weird and frustrating. I used the migration tool that Google provided. I'll see what I can do (but I'll be away the next few days at least, so I probably won't be able to handle it before next week).

@mp1409
Copy link
Author

mp1409 commented Oct 21, 2016

Hi again,
this issue is kind of pressing for FreeBSD, as we are currently not able to install LuaDBI and thus Prosody with Postgres or SQLite due to the lack a valid download location.

However, I was able to download the releases from Google Code via the Internet Archive Wayback Machine and diffed them against this Github repo. The following commits would have to be tagged:

Commit Date According version
23cdfd9 2009-02-17 v0.1
298d7f3 2009-04-18 v0.2
a664e1a 2009-09-01 v0.3
832a219 2009-09-18 v0.4
58513d5 2010-07-18 v0.5

@mwild1: I would have sent you a pull request, but unfortunately there is no possibility to add tags to pull requests. If there is anything else I could do, please just let me know. If you prefer, I could also migrate the repository to a "luadbi" project on GitHub and add the tags there myself. However, I won't do this without your approval, because I do not consider myself fluent in Lua.

@moteus
Copy link

moteus commented Oct 21, 2016

@mp1409 I hope you realize that sources on luarocks server do not match to sources in this repo?
So making tags need after do sync. Checkout #32

@mp1409
Copy link
Author

mp1409 commented Oct 21, 2016

I understand that it is an undesirable situation that the luarocks version does not match this repo. However, my priority is to fix LuaDBI on FreeBSD. And the FreeBSD LuaDBI port depends on the version 0.5 from the original Google Code repo, which exactly matches commit 58513d5, and not the luarocks version. This means syncing to the luarocks version and tagging that as v0.5 might break the build on FreeBSD again...

Anyway, I can only make suggestions, it is upon the Prosody maintainers (i.e. @mwild1) to decide.

@fliiiix
Copy link

fliiiix commented Apr 1, 2017

Is there any chance that we getting that or at least a 0.6 release?

@sparked435
Copy link
Collaborator

Tagged version 0.5 as specified above.

Additionally, 0.6 is released.

@fliiiix
Copy link

fliiiix commented Aug 25, 2017

@sparked435 thank you! I will see if we can update the ports in FreeBSD now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants