Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Render koopa sprites with transparent background #85

Merged
merged 1 commit into from
Oct 24, 2020
Merged

fix: Render koopa sprites with transparent background #85

merged 1 commit into from
Oct 24, 2020

Conversation

mitruly
Copy link
Contributor

@mitruly mitruly commented Oct 24, 2020

Description
Updated koopa sprites to a transparent background. The current koopas render with a non-transparent background:
koopa_non_transparent

Screen capture of game rendered with koopa sprites on a transparent background:
koopa_transparent

Fixes #84.

@mitruly mitruly changed the title fix: Convert koopas to transparent background fix: Convert koopa sprites to transparent background Oct 24, 2020
@mitruly mitruly changed the title fix: Convert koopa sprites to transparent background fix: Render koopa sprites with transparent background Oct 24, 2020
@mx0c mx0c merged commit 47b2170 into mx0c:master Oct 24, 2020
@mx0c mx0c mentioned this pull request Oct 24, 2020
Merged
@mx0c
Copy link
Owner

mx0c commented Oct 24, 2020

Hey, could you ellaborate what you changed in the png ? Because unfortunately this results in weird lookin koopas for me.
image

Also the problem you stated isnt there for me. Maybe this is a MacOS or pygame version related issue ?

@deltea
Copy link
Contributor

deltea commented Oct 24, 2020

I don't have that problem either

@mitruly mitruly mentioned this pull request Oct 24, 2020
Closed
@mitruly
Copy link
Contributor Author

mitruly commented Oct 24, 2020

@mx0c I removed the background (which appears as a teal tint) for me. I can dig into this a bit more if both of you are not experiencing this issue.

Are you both running Linux or Windows?

@deltea
Copy link
Contributor

deltea commented Oct 24, 2020

I am running on a Windows 7

@mx0c
Copy link
Owner

mx0c commented Oct 25, 2020

win 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Koopas not rendering with transparent background
3 participants
@mitruly @mx0c @deltea