Workaround to prevent transport: http2Server.HandleStreams failed to …

[tony-assembly]

…read frame issue

@bmon @awilmore

This is the second part of the noisy logs for health checks, what are your thoughts on this, supposedly this works, and I have verified it locally, this is a fork of the original health check cmd that we build and use and I have applied only a small change.

This should prevent the lines:

[transport] transport: http2Server.HandleStreams failed to read frame: read tcp 127.0.0.1:8080->127.0.0.1:34024: read: connection reset by peer

the alternative is to do the same thing for this line with sumo, but I think this one would be fairly critical if it happens outside of health checks right?

let me know on your thoughts

[awilmore]

@tony-assembly the log filter is applied to an entire collector, so all resources running in a cluster will be subjected to the filter, and we could end up losing logs for non-related things.

In this case I'd go for the code change.

[bmon]

I agree. While it's a shame to have to maintain a fork, the initial codebase and change are simple enough, so I think you've got the right approach here.

[tony-assembly]

Thanks team! I will merge this in, are you guys happy to action whatever we need to do to replace the current health check with this?