Improve display of token interaction transactions in transaction view #12
Assignees
Comments
kiliw
changed the title
ghost
pushed a commit
that referenced
this issue
Mar 13, 2019
…oken-interactions-in-transaction-view Fix #12. Interactions with the smart contract are now shown as 'contract interactions'
|
If you try to send say 0.01 KETH to the same address that your sending it from (i.e. in Etherscan this is shown as a SELF transaction rather than an OUT or IN), then in the "Transactions" view it shows two rows with "Sent To: 0x...", when instead it would make sense if there was one row with "Sent to:" and another row with "Received From: 0x...". Or even better if it were just a single row representing the SELF transaction that says something like "Sent To Yourself" (without specifying the recipient address since it's shown at the top of the window. |
ltfschoen
added a commit
to ltfschoen/mxc-wallet
that referenced
this issue
Aug 3, 2019
…ontract interactions
ltfschoen
added a commit
to ltfschoen/mxc-wallet
that referenced
this issue
Aug 3, 2019
…out appearing on multiple rows
|
Consider using this faucet to transfer ERC20 tokens to a kovan address https://erc20faucet.com/ |
ltfschoen
added a commit
to ltfschoen/mxc-wallet
that referenced
this issue
Aug 3, 2019
…s to all contracts and self-transactions * [x] Add some docs and refactor to `getTransaction` * [x] Add `isRecipientContract` to detect ERC20 token transfers (i.e. using https://erc20faucet.com/), since the `isContractInteraction` function does not appear to detect them * [x] Add support for detecting when transaction was sent to the original sender by using `tweakTxs` to add type `self-interaction` * [x] Call `tweakTxs` for both `refreshTransactions` and `fetchTransactions` so that UI always shows the correct values * [x] Removed the `direction` function as it didn't appear to be necessary (unnecessary complexity) Note: Extends upon changes in PR mxc-foundation@764576a Note: Incorporates approaches that were adopted in PR https://github.com/mxc-foundation/mxc-wallet/pull/18/files, which was incorrectly using the 'master' branch instead of the 'develop' branch, so it didn't have any of the changes that had already been made in PR mxc-foundation@764576a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current behaviour
In the transactions view we show contract interaction transactions as "sending 0 ether". This is confusing for the user.
Expected behaviour
If a transaction is a contract interaction we should just show an information "is contract interaction" and the address of the token and a link to the transaction.
QA
Create some transactions with your metamask wallet like buying tokens, using a smart contract, sending erc20 tokens. Make sure all of these show in the transactions view and all of them only say "contract interaction".
The text was updated successfully, but these errors were encountered: