Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjC AnyPromise and SwiftPackageManager (SPM) #1193

Open
wants to merge 17 commits into
base: v6
Choose a base branch
from
Open

ObjC AnyPromise and SwiftPackageManager (SPM) #1193

wants to merge 17 commits into from

Commits on May 27, 2021

  1. Made AnyPromise available as a "normal" type to both Swift and Object… 

    …ive-C even when used with Swift Packe Manager.
    @DG0BAB @mxcl
    DG0BAB authored and mxcl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    e858bdf View commit details
    Browse the repository at this point in the history

  2. Split up the PromiseKit package into two targets. One for pure Swift … 

    …and another for Objective-C

Targets must be Swift or Objective-C only. Mixing languages in one target is not supported by SPM.
Both targets get integrated into the PromiseKit library product
    @DG0BAB @mxcl
    DG0BAB authored and mxcl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    1e2e117 View commit details
    Browse the repository at this point in the history

  3. Set source path 

    Set public header path so that Objective-C projects can include and find "PromiseKit.h"
In Objective-C projects @import PromiseKitObjC; can be used as well.
    @DG0BAB @mxcl
    DG0BAB authored and mxcl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    32a6226 View commit details
    Browse the repository at this point in the history

  4. Added missing import

    @DG0BAB @mxcl
    DG0BAB authored and mxcl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    fc3af24 View commit details
    Browse the repository at this point in the history

  5. Reversed some earlier changes because a forward declaration of AnyPro… 

    …mise is sufficient at this point.
    @DG0BAB @mxcl
    DG0BAB authored and mxcl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    3e4953d View commit details
    Browse the repository at this point in the history

  6. Moved AnyPromise.swift to the Sources.swift group

    @DG0BAB @mxcl
    DG0BAB authored and mxcl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    6faf064 View commit details
    Browse the repository at this point in the history

  7. Some commenting

    @DG0BAB @mxcl
    DG0BAB authored and mxcl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    9ebcca4 View commit details
    Browse the repository at this point in the history

  8. Changed visibility of box to internal because it it used in an extens… 

    …ion to AnyPromise in the file CustomStringConvertible.swift
    @DG0BAB @mxcl
    DG0BAB authored and mxcl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    39d433e View commit details
    Browse the repository at this point in the history

  9. Changed podspec to include my GitHub-URL

    @DG0BAB @mxcl
    DG0BAB authored and mxcl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    928257c View commit details
    Browse the repository at this point in the history

  10. Reversed changes to podspec file

    @DG0BAB @mxcl
    DG0BAB authored and mxcl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    2ee834d View commit details
    Browse the repository at this point in the history

  11. Try to fix Travis build

    @DG0BAB @mxcl
    DG0BAB authored and mxcl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    d4af4bc View commit details
    Browse the repository at this point in the history

  12. Minor change to the dependencies

    @DG0BAB @mxcl
    DG0BAB authored and mxcl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    d57f105 View commit details
    Browse the repository at this point in the history

  13. Removed obsolete code

    @DG0BAB @mxcl
    DG0BAB authored and mxcl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    355f893 View commit details
    Browse the repository at this point in the history

  14. Changed preprocessor conditional imports

    @DG0BAB @mxcl
    DG0BAB authored and mxcl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    3107c51 View commit details
    Browse the repository at this point in the history

  15. Fixed typo in dependencies 

    Fixed formatting
    @DG0BAB @mxcl
    DG0BAB authored and mxcl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    1e77c7c View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Changed package.swift for swift versions >= 5.3 to also include the P… 

    …romiseKitObjC target.

This makes AnyPromise available when PromiseKit is included with SPM for Swift versions >= 5.3
    @DG0BAB
    DG0BAB committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    26b5b6e View commit details
    Browse the repository at this point in the history

  2. Fixed errors while resolving includes

    @DG0BAB
    DG0BAB committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    10de79f View commit details
    Browse the repository at this point in the history