Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [[AnyPromise alloc] init] #1211

Merged
merged 1 commit into from
May 25, 2021
Merged

Fix [[AnyPromise alloc] init] #1211

merged 1 commit into from
May 25, 2021

Conversation

RomanPodymov
Copy link
Collaborator

@RomanPodymov RomanPodymov commented May 25, 2021

Hello.
Thank you for PromiseKit.
Fix #1175. It looks like the attributes from Objective-C categories are not visible in Swift.
Found related bug here.

@mxcl mxcl merged commit d7933cc into mxcl:master May 25, 2021
@mxcl
Copy link
Owner

mxcl commented May 25, 2021

Merged since macOS passed. The failure was my error, fixed in master for new PRs. Thanks for the PR 🙏🏻

@jfahrenkrug
Copy link
Contributor

@RomanPodymov @mxcl Fantastic, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it illegal to construct AnyPromise() in Swift without arguments
3 participants