synchronize channel actions that happen in the threadpool #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessing channels from multiple threads for messsage acknowledgement will crash a channel and stop messages from being received on that channel this isn't very clear in the documentation for march_hare/bunny, but it is explicitly addresses here: rabbitmq/rabbitmq-java-client#53
| class Synchronizer | ||
| def initialize(delegate) | ||
| @delegate = delegate | ||
| @mutex = ::Thread::Mutex.new |
There was a problem hiding this comment.
maybe a ruby-2 thing, but thought Mutex was a top level class ::Mutex ... ?
|
Looks good. Thanks for looking into this. |
| @@ -7,6 +7,12 @@ def cancel_consumers! | |||
| march_hare_consumers.each(&:cancel) | |||
| end | |||
|
|
|||
| def create_queue(channel, queue_name, queue_options) | |||
| queue = ::MarchHare::Queue.new(channel, queue_name, queue_options) | |||
| queue.declare! | |||
There was a problem hiding this comment.
those integration tests just saved my bacon again! It turns out that building a queue explicitly like this doesn't automatically declare it with the broker the way channel.queue does. 🌈
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing channels from multiple threads for messsage acknowledgement will crash a channel and stop messages from being received on that channel this isn't very clear in the documentation for march_hare/bunny, but it is explicitly addressed here: rabbitmq/rabbitmq-java-client#53
/cc @quixoten @abrandoned @brettallred @brianbroderick