meson build system updates #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, it’s really worth combining the build scripts, but it seems that this is already beyond the scope of this task? @giantplaceholder , what do you say? |
I would suggest opening another issue and track the build scripts rewrite there, and mark the new ticket as dependency of this one. |
mxlgv
requested changes
Mar 29, 2024
mxlgv
requested changes
Mar 29, 2024
vlomovtsev
force-pushed
the
vlomovts/openssl-devel-rebased
branch
3 times, most recently
from
7769cbd
to
752c27f
Compare
vlomovtsev
force-pushed
the
vlomovts/openssl-devel-rebased
branch
2 times, most recently
from
60ef09a
to
97b7b37
Compare
mxlgv
reviewed
Mar 29, 2024
vlomovtsev
force-pushed
the
vlomovts/openssl-devel-rebased
branch
from
97b7b37
to
5c316cd
Compare
giantplaceholder
approved these changes
Mar 29, 2024
mxlgv
requested changes
Mar 29, 2024
mxlgv
requested changes
Mar 29, 2024
vlomovtsev
force-pushed
the
vlomovts/openssl-devel-rebased
branch
2 times, most recently
from
6b05a2d
to
0997003
Compare
mxlgv
requested changes
Mar 29, 2024
vlomovtsev
force-pushed
the
vlomovts/openssl-devel-rebased
branch
3 times, most recently
from
78ec6af
to
9ee136c
Compare
mxlgv
approved these changes
Apr 1, 2024
While using meson some issues were faced with link and application startup. This commit is to put fixes for the following issues: - missed conversation_details.css file; add conversation_details.css to the main/data/gresources.xml; - the 'localtime_r' symbol can't be found while linking application add POSIX_C_SOURCES=1 macro definition - meson configure complains that xmpp-vala package version is not set set xmpp-vala version to 0.1 - application startup failures due to unresolved symbols while creating initial UI fix: put '--export-all-symbols' to the main/meson.build for mingw64 build - segmentation fault while running app built by meson meson.build: add _WIN32 definefor vala compilation - main/meson.build: add _FILE_OFFSET_BITS definition (sync with cmake cfg) - main/meson.build: compile window resources (fix missed window icon) Signed-off-by: Vadim Lomovtsev <jelezny@gmail.com>
Signed-off-by: Vadim Lomovtsev <jelezny@gmail.com>
This commit is to enable plugin to be build with meson for Windows (mingw64) build. Signed-off-by: Vadim Lomovtsev <jelezny@gmail.com>
Signed-off-by: Vadim Lomovtsev <jelezny@gmail.com>
Signed-off-by: Vadim Lomovtsev <jelezny@gmail.com>
vlomovtsev
force-pushed
the
vlomovts/openssl-devel-rebased
branch
from
9ee136c
to
08a163c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief
Minor set of changes in order to enable Windows meson-based build.
Changes
This PR contains following changes:
Notes
Probably we might want to combine the build-win64.sh (which triggers Cmake-based build) and new build-meson-windows.sh files into one, allowing user to select preferable build system.