Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson build system updates #31

Merged
merged 7 commits into from
Apr 1, 2024

Conversation

vlomovtsev
Copy link
Collaborator

Brief

Minor set of changes in order to enable Windows meson-based build.

Changes

This PR contains following changes:

  • fix build & runtime issues, while building Dino with meson & mingw64 for Windows;
  • merge initial OpenSSL support, but keep it disabled (optional), as for calls (ice plugin) we still need to port some additional stuff;
  • enable win32-fonts plugin for meson-based Windows build;
  • enable windows-notification plugin for meson-based Windows build;
  • new script build-meson-windows.sh added to run build in one command;

Notes

Probably we might want to combine the build-win64.sh (which triggers Cmake-based build) and new build-meson-windows.sh files into one, allowing user to select preferable build system.

@mxlgv
Copy link
Owner

mxlgv commented Mar 28, 2024

Yes, it’s really worth combining the build scripts, but it seems that this is already beyond the scope of this task? @giantplaceholder , what do you say?

@giantplaceholder
Copy link
Collaborator

Yes, it’s really worth combining the build scripts, but it seems that this is already beyond the scope of this task? @giantplaceholder , what do you say?

I would suggest opening another issue and track the build scripts rewrite there, and mark the new ticket as dependency of this one.

@mxlgv mxlgv self-requested a review March 29, 2024 12:23
plugins/windows-notification/po/ar.po Outdated Show resolved Hide resolved
meson.build Show resolved Hide resolved
main/meson.build Show resolved Hide resolved
@vlomovtsev vlomovtsev force-pushed the vlomovts/openssl-devel-rebased branch 3 times, most recently from 7769cbd to 752c27f Compare March 29, 2024 14:14
@vlomovtsev vlomovtsev self-assigned this Mar 29, 2024
@vlomovtsev vlomovtsev force-pushed the vlomovts/openssl-devel-rebased branch 2 times, most recently from 60ef09a to 97b7b37 Compare March 29, 2024 14:19
Copy link
Collaborator

@giantplaceholder giantplaceholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further comments from me at this time.

build-win64.sh Outdated Show resolved Hide resolved
build-meson-windows.sh Outdated Show resolved Hide resolved
@vlomovtsev vlomovtsev force-pushed the vlomovts/openssl-devel-rebased branch 2 times, most recently from 6b05a2d to 0997003 Compare March 29, 2024 15:19
build-win64.sh Outdated Show resolved Hide resolved
@vlomovtsev vlomovtsev force-pushed the vlomovts/openssl-devel-rebased branch 3 times, most recently from 78ec6af to 9ee136c Compare April 1, 2024 12:07
While using meson some issues were faced with link and application
startup. This commit is to put fixes for the following issues:

- missed conversation_details.css file;
  add conversation_details.css to the main/data/gresources.xml;
- the 'localtime_r' symbol  can't be found while linking application
  add POSIX_C_SOURCES=1 macro definition
- meson configure complains that xmpp-vala package version is not set
  set xmpp-vala version to 0.1
- application startup failures due to unresolved symbols while creating
  initial UI
   fix: put '--export-all-symbols' to the main/meson.build for mingw64 build
- segmentation fault while running app built by meson
  meson.build: add _WIN32 definefor vala compilation
- main/meson.build: add _FILE_OFFSET_BITS definition (sync with cmake
  cfg)
- main/meson.build: compile window resources (fix missed window icon)

Signed-off-by: Vadim Lomovtsev <jelezny@gmail.com>
Signed-off-by: Vadim Lomovtsev <jelezny@gmail.com>
This commit is to enable plugin to be build with meson for Windows
(mingw64) build.

Signed-off-by: Vadim Lomovtsev <jelezny@gmail.com>
Signed-off-by: Vadim Lomovtsev <jelezny@gmail.com>
Signed-off-by: Vadim Lomovtsev <jelezny@gmail.com>
@vlomovtsev vlomovtsev force-pushed the vlomovts/openssl-devel-rebased branch from 9ee136c to 08a163c Compare April 1, 2024 13:08
@mxlgv mxlgv merged commit 9afa4dd into mxlgv:master Apr 1, 2024
4 checks passed
@vlomovtsev vlomovtsev deleted the vlomovts/openssl-devel-rebased branch April 10, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants