Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented negative filters for title and description. #148

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

dop251
Copy link
Contributor

@dop251 dop251 commented May 15, 2020

I'd like to filter out episodes with certain keywords in the title or description. Because Go's regexp engine does not support negative lookaheads it is not possible to do this just by specifying a regexp for title.

I considered the following approaches:

  • Switching to a different regexp engine (extra dependency, not good).
  • Introducing a special syntax for negative filters, e.g. prepending the filter regexp with '!' (hacky).
  • Adding separate negative filters.

In the end I've decided in favour of the last approach. This PR adds negative filters for title as well as positive and negative filters for description.

@mxpv mxpv merged commit 13e77d0 into mxpv:master Jun 8, 2020
@mxpv
Copy link
Owner

mxpv commented Jun 8, 2020

Thanks!

@dop251 dop251 deleted the filters-pr branch June 8, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants