Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to set feed as private #295

Merged
merged 3 commits into from
Apr 8, 2022
Merged

add support to set feed as private #295

merged 3 commits into from
Apr 8, 2022

Conversation

matejdro
Copy link
Contributor

@matejdro matejdro commented Apr 2, 2022

This fixes #188

According to https://support.google.com/podcast-publishers/answer/10315648?hl=en&ref_topic=9476061, <itunes:block> also prevents feed from being added to Google's aggregator, so <googleplay:block> is not neeeded.

@matejdro
Copy link
Contributor Author

matejdro commented Apr 2, 2022

Sorry, I have no idea what the CI error means (never worked with go outside this project). Can you give me a hand, please?

@mxpv
Copy link
Owner

mxpv commented Apr 3, 2022

Hey. Thanks for the contribution!

I think this is because of maligned linter we use:

- maligned

Here is a good read which explain why it complains: https://medium.com/@sebassegros/golang-dealing-with-maligned-structs-9b77bacf4b97

Feel free to disable it if no luck, I'll take a look later.

this is attempt to fix maligned lint error
@mxpv mxpv merged commit f302e44 into mxpv:main Apr 8, 2022
@matejdro
Copy link
Contributor Author

@mxpv Any chance we can get an official release (and docker image) with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Set feed as private
2 participants