Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ChromeDriver autoinstaller and other minor fixes #71

Merged
merged 3 commits into from
Oct 8, 2020

Conversation

outime
Copy link
Contributor

@outime outime commented Oct 8, 2020

  • Uses ChromeDriver autoinstaller in Docker and hence is able to use the latest Chrome version available from the Google repo. I wrote a small script that handles all the download, renaming, permissions etc so it works well.
  • Fixes COPY permissions.
  • Freezed all Python dependencies so every Docker build is mostly the same.
  • Updates README to avoid having to continously sync the requirements.txt with it.

Fixes #58
Fixes #68

@outime outime changed the title Uses ChromeDriver autoinstaller and other minor fixes Use ChromeDriver autoinstaller and other minor fixes Oct 8, 2020
@mxrch mxrch merged commit 1cca50d into mxrch:master Oct 8, 2020
@mxrch
Copy link
Owner

mxrch commented Oct 8, 2020

Thank you @outime !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker build fails due to chrome version Version for 'google-chrome-stable' was not found
4 participants