Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update history pushState to push to silence warning #14

Merged
merged 1 commit into from
May 2, 2016

Conversation

DavidWells
Copy link
Contributor

No description provided.

@mxstbr
Copy link
Owner

mxstbr commented Mar 24, 2016

Thanks David, this PR is very appreciated! Wouldn't this need a react-router update too?

@DavidWells
Copy link
Contributor Author

Hmm not sure. I just did an npm i and I was seeing the warning in console.

On Wed, Mar 23, 2016 at 8:57 PM, Max Stoiber notifications@github.com
wrote:

Thanks David, this PR is very appreciated! Wouldn't this need a
react-router update too?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#14 (comment)

@mxstbr
Copy link
Owner

mxstbr commented May 2, 2016

Sorry for not merging this for so long, this looks perfect, thanks!

@mxstbr mxstbr merged commit 8c093f8 into mxstbr:master May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants