Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize css #48

Merged
merged 1 commit into from
Aug 8, 2016
Merged

optimize css #48

merged 1 commit into from
Aug 8, 2016

Conversation

olets
Copy link
Collaborator

@olets olets commented Aug 7, 2016

Refactors CSS, optimizes some styles, drops the borders (see #47). 1/3 reduction!

  • now the buttons are 2px narrower and 2px shorter. To keep them the old size, could do css/modules/_share-buttons.css:166 padding: calc(0.5em + 2px) calc(0.75em + 2px);
  • dropped the :hover, :active, and :focus styles from .resp-sharing-button__link. If you want to make sure other styles like a:hover {color: #000} don't mess things up, could add !important to _share-buttons:css:8, 9, and 10

@mxstbr
Copy link
Owner

mxstbr commented Aug 8, 2016

Awesome, this is great! Thanks so much!

@mxstbr mxstbr merged commit 2088b1b into mxstbr:master Aug 8, 2016
@mxstbr
Copy link
Owner

mxstbr commented Aug 8, 2016

could add !important to _share-buttons:css:8, 9, and 10

Let's discuss in this issue: #49

This was referenced Aug 8, 2016
@olets olets mentioned this pull request Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants