Stop self-update picking releases that are not the latest #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andytson-inviqa
force-pushed
the
feature/self-update-latest
branch
4 times, most recently
from
b4f80c8
to
63a45de
Compare
We will be using pre-release tags for testing, which would be listed later than the latest tag
andytson-inviqa
force-pushed
the
feature/self-update-latest
branch
from
63a45de
to
519899c
Compare
dantleech
reviewed
Feb 24, 2023
| } | ||
|
|
||
| $latest = $releases[0]; | ||
| $latest = json_decode($release); |
There was a problem hiding this comment.
not related to this PR, but no error handling here? (e.g. wrong URL, invalid JSON)
dantleech
reviewed
Feb 24, 2023
| } else { | ||
| unlink($file); | ||
| } | ||
| } |
There was a problem hiding this comment.
FYI I introduced a Workspace class which does this sort of thing for tests (and isn't confusing in this project):
// abstract test class in test directory
public function workspace(): Workspace
{
$workspace = new Workspace(__DIR__ . '/Workspace');
}
// setup
$this->workspace()->reset();
// test
$this->workspace()->...
dantleech
reviewed
Feb 24, 2023
| if (!file_exists($dir)) { | ||
| mkdir($dir); | ||
| } | ||
| $contents = file_get_contents(__DIR__ . '/fixtures/tpl/latest.json'); | ||
| $contents = str_replace(['%%browserDownloadUrl%%', '%%versionTag%%'], [$releasePath, $version], $contents); | ||
|
|
||
| file_put_contents(__DIR__ . '/fixtures/generated/' . $name, $contents); |
There was a problem hiding this comment.
if using Workspace this becomes $workspace->put('fixtures/generated.. etc (it should take care of reating parent dirs etc)
dantleech
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will be using pre-release tags for testing, which would be listed later than the latest tag