-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config refactor #34
Open
gravestench
wants to merge
3
commits into
my5G:master
Choose a base branch
from
gravestench:config_refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Config refactor #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* moved `~/cmd/app.go` to `~/cmd/my5g-RANTester/main.go` * refactored logging, command declaration * split into multiple files * switched to using constants and fmt.Sprintf for formatting stuff
running now looks like this: go run ./cmd/my5g-RANTester/
|
here's what running with a command looks like: go run ./cmd/my5g-RANTester/ -l=6 ue
|
here's what default verbosity looks like, with an invalid config path specified: go run ./cmd/my5g-RANTester/ --config=/foo/bar.yaml ue
|
* config global state removed from the config module * config global state now resides in main, TODO to remove it * config now creates a default if none are found * added command line option for specifying the config file * added command line option to specify the log level * config directory now looks in user dir, in a platform agnostic way. ex: on linux, will typically look in `~/.config/my5g/RANTester` for file `config.yml` * updated go.mod to use go v1.16 * embedded default config file data * errors are now bubbled up appropriately * depends on my5G#33
gravestench
force-pushed
the
config_refactor
branch
from
March 2, 2022 00:06
ea6a514
to
0108ab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #33!
ex: on linux, will typically look in
~/.config/my5g/RANTester
for fileconfig.yml