Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.8.2: Support telneting with auth for Scrapy>=1.5.2 #13

Merged
merged 2 commits into from
Aug 4, 2019
Merged

Conversation

my8100
Copy link
Owner

@my8100 my8100 commented Aug 4, 2019

No description provided.

@pep8speaks
Copy link

pep8speaks commented Aug 4, 2019

Hello @my8100! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 22:121: E501 line too long (158 > 120 characters)

Comment last updated at 2019-08-04 13:47:39 UTC

@codecov
Copy link

codecov bot commented Aug 4, 2019

Codecov Report

Merging #13 into master will increase coverage by 0.27%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   87.33%   87.61%   +0.27%     
==========================================
  Files           9        9              
  Lines         892      896       +4     
==========================================
+ Hits          779      785       +6     
+ Misses        113      111       -2
Impacted Files Coverage Δ
logparser/scrapylogparser.py 98.24% <100%> (+0.03%) ⬆️
logparser/__version__.py 100% <100%> (ø) ⬆️
logparser/settings.py 100% <100%> (ø) ⬆️
logparser/telnet.py 86.75% <75%> (+0.17%) ⬆️
logparser/utils.py 91.11% <0%> (+4.44%) ⬆️

@my8100 my8100 merged commit 7117860 into master Aug 4, 2019
@my8100 my8100 deleted the v0.8.2 branch August 4, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants