Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: NSID can be immutable object #1112

Closed
myConsciousness opened this issue Dec 18, 2023 · 0 comments · Fixed by #1113
Closed

Feature Request: NSID can be immutable object #1112

myConsciousness opened this issue Dec 18, 2023 · 0 comments · Fixed by #1113
Assignees
@myConsciousness
Labels
feat A label indicating that this issue is a new feature. help wanted Extra attention is needed nsid A label indicating the package `nsid`. untriaged A label Indicating this Issue has not yet been initiated.

Comments

@myConsciousness
Copy link
Owner

  • Add .of constructor.
    • It uses the given arguments as-is and does not validate them.
    • This allows for an immutable NSID under certain conditions.
@myConsciousness myConsciousness added help wanted Extra attention is needed nsid A label indicating the package `nsid`. untriaged A label Indicating this Issue has not yet been initiated. feat A label indicating that this issue is a new feature. labels Dec 18, 2023
@myConsciousness myConsciousness self-assigned this Dec 18, 2023
myConsciousness added a commit that referenced this issue Dec 18, 2023
@myConsciousness
feat: Immutable NSID (#1112)
11ef590
@myConsciousness myConsciousness linked a pull request Dec 18, 2023 that will close this issue
feat: Immutable NSID (#1112) #1113
Merged
6 tasks
myConsciousness added a commit that referenced this issue Dec 18, 2023
@myConsciousness
Merge pull request #1113 from myConsciousness/1112-feature-request-ns…
e8e7090 
…id-can-be-immutable-object

feat: Immutable NSID (#1112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myConsciousness myConsciousness

Labels
feat A label indicating that this issue is a new feature. help wanted Extra attention is needed nsid A label indicating the package `nsid`. untriaged A label Indicating this Issue has not yet been initiated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Immutable NSID (#1112) myConsciousness/atproto.dart
1 participant
@myConsciousness