Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Suggestion: Upload blob from bytes, not File #556

Closed
myConsciousness opened this issue Jun 27, 2023 · 0 comments · Fixed by #557
Closed

Improve Suggestion: Upload blob from bytes, not File #556

myConsciousness opened this issue Jun 27, 2023 · 0 comments · Fixed by #557
Assignees
@myConsciousness
Labels
atproto_core A label indicating the package `atproto_core`. atproto A label indicating the package `atproto`. bluesky A label indicating the package `bluesky`. xrpc A label indicating the package `xrpc`.

Comments

@myConsciousness
Copy link
Owner

1. What could be improved

The File in dart:io is useful, but Flutter for Web cannot use this object due to browser specification restrictions. Modify to upload from byte data.

2. Why should this be improved

3. Any risks?

4. More information
@myConsciousness myConsciousness added enhancement atproto_core A label indicating the package `atproto_core`. atproto A label indicating the package `atproto`. bluesky A label indicating the package `bluesky`. xrpc A label indicating the package `xrpc`. labels Jun 27, 2023
@myConsciousness myConsciousness self-assigned this Jun 27, 2023
myConsciousness added a commit that referenced this issue Jun 27, 2023
@myConsciousness
fix: fixed for the issue (#556)
7983838
@myConsciousness myConsciousness linked a pull request Jun 27, 2023 that will close this issue
fix: fixed for the issue (#556) #557
Merged
7 tasks
myConsciousness added a commit that referenced this issue Jun 27, 2023
@myConsciousness
Merge pull request #557 from myConsciousness/556-improve-suggestion-u…
996dbdb 
…pload-blob-from-bytes-not-file

fix: fixed for the issue (#556)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myConsciousness myConsciousness

Labels
atproto_core A label indicating the package `atproto_core`. atproto A label indicating the package `atproto`. bluesky A label indicating the package `bluesky`. xrpc A label indicating the package `xrpc`.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fixed for the issue (#556) myConsciousness/atproto.dart
1 participant
@myConsciousness