Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Suggestion: subscribeRepos #719

Closed
myConsciousness opened this issue Aug 28, 2023 · 0 comments · Fixed by #721
Closed

Improve Suggestion: subscribeRepos #719

myConsciousness opened this issue Aug 28, 2023 · 0 comments · Fixed by #721
Assignees
@myConsciousness
Labels
atproto/lexicon/sync A label indicating the service related to `com.atproto.sync.*`. atproto A label indicating the package `atproto`.
Milestone
Repo Sync Updates

Comments

@myConsciousness
Copy link
Owner

1. What could be improved

Add required field to the commit event:

  • rev
  • since

2. Why should this be improved

3. Any risks?

  • Possibly deprecate the required prev field

4. More information
@myConsciousness myConsciousness added atproto A label indicating the package `atproto`. atproto/lexicon/sync A label indicating the service related to `com.atproto.sync.*`. labels Aug 28, 2023
@myConsciousness myConsciousness self-assigned this Aug 28, 2023
@myConsciousness myConsciousness added this to the Repo Sync Updates milestone Aug 29, 2023
myConsciousness added a commit that referenced this issue Aug 30, 2023
@myConsciousness
🚀 refactor: added params (#719)
94836b7
@myConsciousness myConsciousness linked a pull request Aug 30, 2023 that will close this issue
🚀 refactor: Repo Sync Updates #721
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myConsciousness myConsciousness

Labels
atproto/lexicon/sync A label indicating the service related to `com.atproto.sync.*`. atproto A label indicating the package `atproto`.
Projects
None yet
Milestone
Repo Sync Updates
Development

Successfully merging a pull request may close this issue.

🚀 refactor: Repo Sync Updates myConsciousness/atproto.dart
1 participant
@myConsciousness