Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed for the issue (#564) #565

Conversation

myConsciousness
Copy link
Owner

1. Description

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

@netlify
Copy link

netlify bot commented Jul 2, 2023

Deploy Preview for jade-haupia-45bdc2 canceled.

Name Link
🔨 Latest commit 684994a
🔍 Latest deploy log https://app.netlify.com/sites/jade-haupia-45bdc2/deploys/64a0d347c267350008bc26db

@github-actions github-actions bot added documentation Improvements or additions to documentation test atproto_core A label indicating the package `atproto_core`. atproto A label indicating the package `atproto`. bluesky A label indicating the package `bluesky`. bluesky_cli A label indicating the package `bluesky_cli`. atproto/lexicon/servers A label indicating the service related to `com.atproto.server.*`. labels Jul 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2023

Codecov Report

Merging #565 (684994a) into main (4b34add) will decrease coverage by 3.26%.
The diff coverage is 90.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   67.80%   64.54%   -3.26%     
==========================================
  Files         208      214       +6     
  Lines        1960     2062     +102     
==========================================
+ Hits         1329     1331       +2     
- Misses        631      731     +100     
Impacted Files Coverage Δ
...atproto/lib/src/identities/identities_service.dart 100.00% <ø> (ø)
...kages/atproto/lib/src/servers/servers_service.dart 100.00% <ø> (ø)
...es/atproto_core/lib/src/client/client_context.dart 0.00% <0.00%> (ø)
packages/bluesky/lib/src/bluesky.dart 0.00% <ø> (ø)
...atproto/lib/src/moderation/moderation_service.dart 100.00% <100.00%> (ø)
...s/atproto_core/lib/src/client/client_resolver.dart 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the atproto/lexicon/identities A label indicating the service related to `com.atproto.identity.*`. label Jul 2, 2023
@github-actions github-actions bot added the atproto/lexicon/moderation A label indicating the service related to `com.atproto.moderation.*`. label Jul 2, 2023
@myConsciousness myConsciousness merged commit 648a561 into main Jul 2, 2023
@myConsciousness myConsciousness deleted the 564-feature-request-clarify-access-areas-for-instances-created-with-anonymous branch July 2, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atproto_core A label indicating the package `atproto_core`. atproto/lexicon/identities A label indicating the service related to `com.atproto.identity.*`. atproto/lexicon/moderation A label indicating the service related to `com.atproto.moderation.*`. atproto/lexicon/servers A label indicating the service related to `com.atproto.server.*`. atproto A label indicating the package `atproto`. bluesky_cli A label indicating the package `bluesky_cli`. bluesky A label indicating the package `bluesky`. documentation Improvements or additions to documentation test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Clarify access areas for instances created with .anonymous
2 participants