Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from atomikos to narayana #363

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

TheOnlyAl
Copy link
Contributor

Removed Atomikos dependencies and code from pom.xml
Added narayana-jta-jakarta:5.13.1.Final dependency to pom.xml
Removed not needed properties from mybatis-config_jta.xml
Added NarayanaDataSourceWrapper which is needed to wrap a XADataSource
Added a primary key to CreateDB_JTA.sql to avoid tests sometimes failing
Changed JtaDatasourceFactory to use Narayana

Removed Atomikos dependencies and code from pom.xml
Added narayana-jta-jakarta:5.13.1.Final dependency to pom.xml
Removed not needed properties from mybatis-config_jta.xml
Added NarayanaDataSourceWrapper which is needed to wrap a XADataSource
Added a primary key to CreateDB_JTA.sql to avoid tests sometimes failing
Changed JtaDatasourceFactory to use Narayana
@TheOnlyAl
Copy link
Contributor Author

Hi there.

This PR is intented to fix the unit tests for Issue: #242 using the mentioned Narayana library in #356.
I hope this will help you to create a release for the Jakarta version of mybatis-cdi.

Since i do not have a lot of experience with Narayana i tried to make it work, but do now know how robust the solution is.

If you have any questions, feel free to ask away.

@hazendaz
Copy link
Member

hazendaz commented Feb 3, 2023

@TheOnlyAl Thanks! Started the run on this, will take a look later, if this works out, yes will get release out shortly then.

@hazendaz
Copy link
Member

hazendaz commented Feb 3, 2023

@TheOnlyAl Code looks great! Good job on that! Merging it in. I plan to release with this one last javax cut then I'll back up that branch, merge in the jakarta stuff and work to get that released. This will come after I release mybatis core this weekend. So potentially I get all this out this weekend.

@hazendaz hazendaz merged commit 1f958a7 into mybatis:jakarta Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants