Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter site content without hijacking main resources #763

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

hboutemy
Copy link
Contributor

@hboutemy hboutemy commented Dec 3, 2022

fixes #759

this is the filtering strategy that uses explicit maven-resources-plugin execution (bound to site lifecycle) instead of hijacking main resources

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.404% when pulling 517caba on hboutemy:site-resources into f7e2020 on mybatis:master.

Copy link

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea when you don't need all features of Velocity.

@hazendaz hazendaz self-assigned this Dec 5, 2022
@hazendaz
Copy link
Member

hazendaz commented Dec 5, 2022

@hboutemy Thanks!

@hazendaz hazendaz merged commit 207e94c into mybatis:master Dec 5, 2022
@hboutemy hboutemy deleted the site-resources branch December 8, 2022 07:19
@kazuki43zoo kazuki43zoo added this to the 3.0.1 milestone May 13, 2023
@kazuki43zoo kazuki43zoo added backport to other version Backport to other maintenance version done backported Backporting is doned labels May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to other version Backport to other maintenance version done backported Backporting is doned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants