Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Feature #276 ACP: basic forums management #275

Merged
merged 6 commits into from
Jan 29, 2017
Merged

Feature #276 ACP: basic forums management #275

merged 6 commits into from
Jan 29, 2017

Conversation

Matslom
Copy link
Contributor

@Matslom Matslom commented Jan 8, 2017 •
edited
Loading

I skipped for now deleting forum and editing forums order.
#276

@euantorano
Copy link
Member

euantorano commented Jan 8, 2017 via email

@Matslom Matslom changed the title Feature ACP: basic forums management Feature #276 ACP: basic forums management Jan 8, 2017
@Ben-MyBB
Copy link
Member

Ben-MyBB commented Jan 8, 2017

Really good work @Matslom

@QuietSoul
Copy link

Yes! good job @Matslom

ATofighi
ATofighi reviewed Jan 8, 2017
View reviewed changes
app/Twig/Extensions/ListAllForums.php
foreach ($forums as $forum) {
$result .= view($template, compact('forum', 'level', 'options'))->render();
if ($forum->children->count() > 0) {
$result .= $this->renderForums($forum->children, $template, $options, ++$level);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++$level should be $level + 1...
++$level may change the level of the next forums..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

ATofighi
ATofighi reviewed Jan 8, 2017
View reviewed changes
resources/views/admin/partials/forums/forum_form.twig
</span>
</div>
<select id="order" name="order">
<option value="0">NuLL</option>
Copy link
Contributor

@ATofighi ATofighi Jan 8, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NuLL should be inserted to langs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole forum sorting need rewrite using javascript. It's placeholder so I leave this as is for now

ATofighi
ATofighi reviewed Jan 8, 2017
View reviewed changes
resources/views/admin/forums/forum-item.twig
<div>
<a href="{{ url_route('forums.show', {'slug': forum.slug, 'id': forum.id}) }}">{{ forum.title }}</a> | Level: {{ level }}
<span style="float:right">
<a href="{{ route('admin.forums.edit', {'id': forum.id}) }}">Edit</a>
Copy link
Contributor

@ATofighi ATofighi Jan 8, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Edit" should be inserted to langs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Matslom
Copy link
Contributor Author

Matslom commented Jan 9, 2017 •
edited
Loading

Thanks @ATofighi for review.

@euantorano euantorano merged commit c9dca01 into mybb:master Jan 29, 2017
@Matslom Matslom deleted the feature/ACP-forums-management branch April 13, 2017 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ATofighi ATofighi ATofighi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Matslom @euantorano @Ben-MyBB @QuietSoul @ATofighi