Benchmarks

[gfoidl]

Fixes #2
Based on top of benchs added in #1

[BenjaminAbt]

The Benchmark project is being created as nuget and published.
We should exclude it.

[BenjaminAbt]

we should move the copied source of UserAgent in the current benchmark project too to compare without caching

[BenjaminAbt]

CI is not triggered, but why?

[gfoidl]

The Benchmark project is being created as nuget and published.
We should exclude it.

What's the easiest way? I can't see the forest of the trees at the moment.

[BenjaminAbt]

done

[BenjaminAbt]

i have a better idea

[gfoidl]

What do you think about 5b8213f?

I verifyed it works as it should.

[BenjaminAbt]

I think the explicit behavior is easier to understand / manage if we use this in other projects etc

[gfoidl]

Makes, sense, I'll revert this one.

[gfoidl]

Damned, I didn't look enough, now it's a merge-commit instead a squash-merge (for linear history).
The defaults did change...re-enabled squash-merging now.

[BenjaminAbt]

Nooo, squad marge does not work with NerdBank GitVersioning!

[gfoidl]

We have this in the other repos too?
Then NerdBank GitVersioning is faulty, as squash merging should be the way to merge PRs for linear history which is much cleaner to follow (and bisect in case of). Merge commits for PRs bring every intermediate commit of a PR into main, but these should be a detail.

[BenjaminAbt]

Yes, we had a large discussion in other repos and decided to not use squash merge

[gfoidl]

decided to not use squash merge

I missed that (can remember the discussion, but not a conclusion), and I'm not fine with not using squash merge. Merge commit ruin the history.
If NerdBank does work only with merge commit it sucks 😢

[BenjaminAbt]

https://github.com/mycsharp/ContentRenderer/issues/16

[gfoidl]

Just read the same issue.
There the NerdBank also sucks. IMO this isn't a solution for versioning, as it only works half-ways.
Do we need to publish a package for each CI build? Who will be using these packages anyway? I'd prefer a package built from main and pushed, and for PRs (to validate it's usage in another project) create some kind of preview (manually).

[BenjaminAbt]

for all I care, we can only ship stable packages

[gfoidl]

👍🏻 agree.