Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended hosts and host metrics api methods #5

Merged
merged 4 commits into from
Dec 28, 2016

Conversation

yoheimuta
Copy link
Collaborator

I want to call /api/v0/hosts.json with any query parameters and /api/v0/hosts/{host_id}/metrics.

Usage examples:

my @args = (service => "service", role => "bastion", 
    role => "batch", status => "working");
my $content = $mackerel->get_hosts(\@args);
my $host_id = "2RnaLGypmBJ"; 
my $args = { name => 'loadavg5', from => '1478744400', to => '1479303590' }; 
my $content = $mackerel->get_host_metrics($host_id, $args);

@yoheimuta
Copy link
Collaborator Author

sorry, I'm going to fix tests.

@yoheimuta
Copy link
Collaborator Author

sorry, I'm going to fix tests.

It's an unrelated issue #6 with this pr, so I reopen it.

@cou929
Copy link
Collaborator

cou929 commented Dec 25, 2016

@yoheimuta The diff looks good but CI has been failed as you mentioned.
I commented to #6 about that.

@yoheimuta
Copy link
Collaborator Author

@cou929 Thank you for advice. 135ee56 fixes a CI failure.

@cou929
Copy link
Collaborator

cou929 commented Dec 28, 2016

@yoheimuta I reviewed 135ee56 and It's okay.
I think you can merge this p-r.
Thank you!

@yoheimuta
Copy link
Collaborator Author

Thanks !

@yoheimuta yoheimuta merged commit 4d76547 into myfinder:master Dec 28, 2016
@yoheimuta yoheimuta deleted the add-hosts_api branch December 28, 2016 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants