Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gitlab-ci): add rubocop linter (with allow_failure) #277

Merged
merged 1 commit into from
Dec 19, 2020

Conversation

myii
Copy link
Owner

@myii myii commented Dec 19, 2020

Use a separate job for rubocop other than the one potentially run by pre-commit

  • The pre-commit check will only be available for formulas that pass the default
    rubocop check -- and must continue to do so
  • This job is allowed to fail, so can be used for all formulas
  • Furthermore, this job uses all of the latest rubocop features & cops,
    which will help when upgrading the rubocop linter used in pre-commit

Use a separate job for `rubocop` other than the one potentially run by `pre-commit`
- The `pre-commit` check will only be available for formulas that pass the default
  `rubocop` check -- and must continue to do so
- This job is allowed to fail, so can be used for all formulas
- Furthermore, this job uses all of the latest `rubocop` features & cops,
  which will help when upgrading the `rubocop` linter used in `pre-commit`
@myii myii force-pushed the feat/add-separate-rubocop-linter branch 2 times, most recently from 21f48de to a584cc3 Compare December 19, 2020 14:23
myii added a commit to saltstack-formulas/apache-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/apt-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/apt-cacher-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/arvados-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/bind-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/cert-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/chrony-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/collectd-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/consul-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/cron-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/deepsea-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/devstack-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/dhcpd-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/django-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/docker-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/eclipse-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/epel-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/exim-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/fail2ban-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/firewalld-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/golang-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/grafana-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/haproxy-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/hostsfile-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/icinga2-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/influxdb-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/iptables-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/rkhunter-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/rng-tools-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/rspamd-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/salt-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/sqldeveloper-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/sqlplus-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/strongswan-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/stunnel-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/sudoers-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/suricata-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/sysctl-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/syslog-ng-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/sysstat-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/systemd-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/telegraf-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/template-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/timezone-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/tomcat-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/ufw-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/users-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/varnish-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/vault-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/vim-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/vsftpd-formula that referenced this pull request Dec 19, 2020
myii added a commit to saltstack-formulas/zabbix-formula that referenced this pull request Dec 19, 2020
@myii myii merged commit 0aa457b into master Dec 19, 2020
@myii myii deleted the feat/add-separate-rubocop-linter branch December 19, 2020 14:50
@myii
Copy link
Owner Author

myii commented Dec 19, 2020

🎉 This PR is included in version 1.229.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@myii myii added the released label Dec 19, 2020
japtain-cack pushed a commit to japtain-cack/docker-formula that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant