-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gitlab-ci): add rubocop
linter (with allow_failure
)
#277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a separate job for `rubocop` other than the one potentially run by `pre-commit` - The `pre-commit` check will only be available for formulas that pass the default `rubocop` check -- and must continue to do so - This job is allowed to fail, so can be used for all formulas - Furthermore, this job uses all of the latest `rubocop` features & cops, which will help when upgrading the `rubocop` linter used in `pre-commit`
myii
force-pushed
the
feat/add-separate-rubocop-linter
branch
2 times, most recently
from
December 19, 2020 14:23
21f48de
to
a584cc3
Compare
myii
added a commit
to saltstack-formulas/apache-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/apt-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/apt-cacher-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/arvados-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/bind-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/cert-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/chrony-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/collectd-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/consul-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/cron-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/deepsea-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/devstack-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/dhcpd-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/django-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/docker-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/eclipse-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/epel-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/exim-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/fail2ban-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/firewalld-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/golang-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/grafana-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/haproxy-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/hostsfile-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/icinga2-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/influxdb-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/iptables-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/rkhunter-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/rng-tools-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/rspamd-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/salt-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/sqldeveloper-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/sqlplus-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/strongswan-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/stunnel-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/sudoers-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/suricata-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/sysctl-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/syslog-ng-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/sysstat-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/systemd-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/telegraf-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/template-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/timezone-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/tomcat-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/ufw-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/users-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/varnish-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/vault-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/vim-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/vsftpd-formula
that referenced
this pull request
Dec 19, 2020
myii
added a commit
to saltstack-formulas/zabbix-formula
that referenced
this pull request
Dec 19, 2020
🎉 This PR is included in version 1.229.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
japtain-cack
pushed a commit
to japtain-cack/docker-formula
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a separate job for
rubocop
other than the one potentially run bypre-commit
pre-commit
check will only be available for formulas that pass the defaultrubocop
check -- and must continue to do sorubocop
features & cops,which will help when upgrading the
rubocop
linter used inpre-commit