Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check argument #45

Merged
merged 2 commits into from
Feb 9, 2019
Merged

Add check argument #45

merged 2 commits into from
Feb 9, 2019

Conversation

jamescurtin
Copy link
Contributor

By specifying the --check argument, the program will exit with a code of 1. This is useful if using as part of a CI pipeline that should fail if changes are necessary.

James Curtin added 2 commits January 30, 2019 12:32
By specifying the --check argument, the program will exit with a code of 1. This is useful if using as part of a CI pipeline that should fail if changes are neccesary
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 99.324% when pulling a1c08a2 on jamescurtin:add-check-argument into 5130533 on myint:master.

@myint
Copy link
Member

myint commented Feb 3, 2019

It seems like this would be equivalent to running pyflakes directly.

@jamescurtin
Copy link
Contributor Author

I think there are a few differences. It is possible that autoflake will only try to fix a subset of issues that pyflake discovers, due to usage of CLI options and # noqa hints. I am not aware of an easy approach to coerce pyflake to only warn about issues that autoflake is configured to correct.

The use case I'm considering requires that contributors to a project run a suite of tests & linting tasks before being allowed to merge a PR. Using pyflake here could potentially prevent someone from merging due to a false positive.

Thoughts on this? And thanks for reviewing!

@myint
Copy link
Member

myint commented Feb 9, 2019

Makes sense to me. Thanks!

@myint myint merged commit 61b09b3 into PyCQA:master Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants