Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix fork addressing urllib exceptions #13

Open
fish2000 opened this issue Sep 20, 2017 · 0 comments
Open

Bugfix fork addressing urllib exceptions #13

fish2000 opened this issue Sep 20, 2017 · 0 comments

Comments

@fish2000
Copy link

I was having trouble running yolk -U, as the entire process would halt whenever the occasion of a transient urllib2.URLError would bubble up to the CLI:

screen shot 2017-09-19 at 11 02 14 pm

… so I forked yolk3k and vendored in retrying – which I used here and here, rather coarsely, to elide halting the program on these exceptions.

The fork works as it should, but it seemed like a biggish change for an unsolicited PR; if you are interested in integrating this stuff upstream, I’d be happy to clean it up and squash it down. Indeed. Thanks in any case, yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant