This repository has been archived by the owner on Mar 23, 2021. It is now read-only.
main: only use local cache on install for -nonet #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2020
Closed
Closed
myitcv
force-pushed
the
fix_cache_miss_on_install_issue
branch
2 times, most recently
from
ff58ee9
to
57535b5
Compare
Using the local module cache for installs unconditionally means that there will be situations where that cache is incomplete and hence the install (and any subsequent step) will fail. Rather we only need to enforce the use of the local module cache when we are in -nonet. Hence we now allow network access in the case of a module cache miss in the non-nonet situation, which is exactly the semantics we intend. Test to follow. Fixes #86
myitcv
force-pushed
the
fix_cache_miss_on_install_issue
branch
from
57535b5
to
2f9db55
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the local module cache for installs unconditionally means that
there will be situations where that cache is incomplete and hence the
install (and any subsequent step) will fail.
Rather we only need to enforce the use of the local module cache when we
are in -nonet.
Hence we now allow network access in the case of a module cache miss in
the non-nonet situation, which is exactly the semantics we intend.
Test to follow.
Fixes #86