Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋🏽
This package cannot be imported in ESM environment even it says it should work in
package.json
.For example, if the downstream consumer has
type: "module"
in theirpackage.json
, the import will fail withERR_MODULE_NOT_FOUND
when the entry tries to resolve internal modules:This can be solved by adding
.js
suffix to the import path and specifymoduleResolution
tonode16
in tsconfig to enforce this rule.I am also adding a ESM-only warning in the README, copied from https://github.com/remarkjs/remark-directive because it seems the remark plugin ecosystem is pretty much ESM-only now.
But I am not sure if this package will work in deno or in the browser, through esm.sh so I didn't copy those instruction over.
After the change, the build passes arethetypeswrong check.
Some reference reading for this ESM issue: