Add support for specifying server_hostname via SNI when connecting #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzkostyan
requested changes
Jul 27, 2022
clickhouse_driver/connection.py
Outdated
| @@ -122,7 +127,7 @@ class Connection(object): | |||
| """ | |||
|
|
|||
| def __init__( | |||
| self, host, port=None, | |||
| self, host, port=None, server_hostname=None, | |||
There was a problem hiding this comment.
server_hostname parameter should be placed at the end or in the "Secure socket parameters" section right after keyfile=None, certfile=None which is preferrable.
This will keep backwards compatibility for those who constructs client like Client('localhost', 9000, 'user', 'pass', 'mydb')
There was a problem hiding this comment.
ah, good feedback, done
|
And add |
xzkostyan
approved these changes
Jul 27, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specifically allows connections to be made over SSH tunnels via separately setting the
server_hostnamewhen constructing the SSL wrapper. Without this, one would have to modify/etc/hoststo achieve the same effect which isn't always possible in all environments.