Skip to content

Commit 938ade8

Browse files
committed
Update DallasTemperatureSensor.ino
Small code improvements
1 parent 30a0b83 commit 938ade8

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

libraries/MySensors/examples/DallasTemperatureSensor/DallasTemperatureSensor.ino

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
#define ONE_WIRE_BUS 3 // Pin where dallase sensor is connected
3333
#define MAX_ATTACHED_DS18B20 16
3434
unsigned long SLEEP_TIME = 30000; // Sleep time between reads (in milliseconds)
35-
OneWire oneWire(ONE_WIRE_BUS);
36-
DallasTemperature sensors(&oneWire);
35+
OneWire oneWire(ONE_WIRE_BUS); // Setup a oneWire instance to communicate with any OneWire devices (not just Maxim/Dallas temperature ICs)
36+
DallasTemperature sensors(&oneWire); // Pass our oneWire reference to Dallas Temperature.
3737
MySensor gw;
3838
float lastTemperature[MAX_ATTACHED_DS18B20];
3939
int numSensors=0;
@@ -44,8 +44,8 @@ MyMessage msg(0,V_TEMP);
4444

4545
void setup()
4646
{
47-
// Startup OneWire
48-
sensors.begin();
47+
// Startup up the OneWire library
48+
sensors.begin();
4949

5050
// Startup and initialize MySensors library. Set callback for incoming messages.
5151
gw.begin();
@@ -78,10 +78,11 @@ void loop()
7878
float temperature = static_cast<float>(static_cast<int>((gw.getConfig().isMetric?sensors.getTempCByIndex(i):sensors.getTempFByIndex(i)) * 10.)) / 10.;
7979

8080
// Only send data if temperature has changed and no error
81-
if (lastTemperature[i] != temperature && temperature != -127.00) {
81+
if (lastTemperature[i] != temperature && temperature != -127.00 && temperature != 85.00) {
8282

8383
// Send in the new temperature
8484
gw.send(msg.setSensor(i).set(temperature,1));
85+
// Save new temperatures for next compare
8586
lastTemperature[i]=temperature;
8687
}
8788
}

0 commit comments

Comments
 (0)