esp8266gateway crashing when receiving I_CONFIG message from new node…

[soward]

… due to attempt to dereference the NULL return of MyMessage::getString()

this fix checks for NULL return from getString and defaults isMetric to true, otherwise attempts the usual match. Works for me so far. Not tested on AVR.

( I AGREE TO THE CLA )

[mysensors-jenkins]

As the author of this pull request is not in my whitelist, I may not build this PR automatically.
A member of the MySensors core team can ask me to verify this pull request by telling me "jenkins, build this please".
The author can be whitelisted to get future PR:s automatically verified by telling me "jenkins, add author to whitelist please".
But remember that I will only listen if you name me with a capital 'J'.
If you would like to submit a PR and not have Jenkins build it for you, you can add "[skip ci]" to your PR "body".

[henrikekblad]

Jenkins, add author to whitelist please

[mysensors-jenkins]

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/MySensorsArduinoPR/187/

[henrikekblad]

@soward
Thanks for spotting this. Just wonder why crash doesn't happen for everybody.

[soward]

Not sure exactly, maybe depends on the exact 8266 device used? This page suggests that 0 and 1 are protected and might be cleared for just such purposes:

http://esp8266-re.foogod.com/wiki/Memory_Map http://esp8266-re.foogod.com/wiki/Memory_Map

but in the crash output always had the same address in the high 0x4010 range, perhaps to some flash that doesn’t exist on the board I was using? ( nodemcu v 0.9 ‘yellow’ board )

On Nov 24, 2015, at 4:59 AM, Henrik Ekblad notifications@github.com wrote:

@soward https://github.com/soward

Thanks for spotting this. Just wonder why crash doesn't happen for everybody.

—
Reply to this email directly or view it on GitHub #264 (comment).

[bblacey]

FYI, I experienced a similar crash when experimenting with a NodeMCU 1.0... It happened when I rebooted one of my nodes... Good catch!