Skip to content

Conversation

tbowmo
Copy link
Contributor

@tbowmo tbowmo commented Jan 4, 2016

Use MY_HW_xx_LED_PIN, if it is defined in board specific files, AND if MY_DEFAULT_xx_LED_PIN is not defined.

Commented out MY_DEFAULT_xx_LED_PIN defines in gateway sketches

if MY_DEFAULT_XX_LED_PIN is defined, it also enables MY_LEDS_BLINKING_FEATURE

If MY_LED_BLINKING_FEATURE is enabled, but no MY_DEFAULT_xx_LED_PIN are defined, then it will undefine MY_LED_BLINKING_FEATURE, as it doesn't make sense to include it if no LED's are defined.

@mysensors-jenkins
Copy link

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/MySensorsArduinoPR/306/

@mysensors-jenkins
Copy link

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/MySensorsArduinoPR/307/

@mysensors-jenkins
Copy link

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/MySensorsArduinoPR/319/

@fallberg
Copy link
Contributor

fallberg commented Jan 7, 2016

Good to go?

@tbowmo
Copy link
Contributor Author

tbowmo commented Jan 7, 2016

Fine by me. Just rebased against development.

tor. 7. jan. 2016 22.05 skrev Patrick Fallberg notifications@github.com:

Good to go?


Reply to this email directly or view it on GitHub
#323 (comment).

fallberg added a commit that referenced this pull request Jan 7, 2016
LED HW definitions in arduino HW files overridable
@fallberg fallberg merged commit cee1dd3 into mysensors:development Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants